From: Eric Sunshine Date: Fri, 11 Sep 2015 17:30:07 GMT Subject: Re: [PATCH v17 00/14] port tag.c to use ref-filter APIs Message-ID: In-Reply-To: On Fri, Sep 11, 2015 at 11:08 AM, Karthik Nayak wrote: > On Thu, Sep 10, 2015 at 10:27 PM, Matthieu Moy > wrote: >> Karthik Nayak writes: >>> Changes in this version: >>> * The arguments of the %(align) atom are interchangeable. >>> * Small grammatical changes. >>> * Small changes in the tests to reflect changes in the align >>> atom code. >> >> Clearly, we're almost there. I did a few minor remarks. I suggest >> (admitedly, Eric suggested of-list to suggest ;-) ) that you reply to >> them by re-sending only individual patches that changed (replying to the >> original patch) so that we can check the new patches individually. I >> think we can do the finishing touches for each patch in a subthread of >> this patch. > > I replied with suggested changes by you and Junio. > Let me know if any other changes to be made :) Hmm, but what actually changed in the re-sent patches? Without a link to the discussion leading up to the re-send of changed-only patches, and without an interdiff, the re-send is opaque and less accessible to the reviewer; which is at odds with Matthieu's suggestion which was intended to make review easier and more streamlined. In addition to a link to the previous round and an interdiff, it would be helpful to reviewers for you to annotate each patch (in the commentary are below the "---" line after your sign-off) with a description of the changes in that patch since the previous round in order to focus the reviewer's attention (where it needs to be) on the latest changes.