From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 30 Sep 2018 04:41:14 GMT
Subject: Re: [PATCH v2 1/1] roll wt_status_state into wt_status and populate in the collect phase
Message-ID: <CAPig+cTm_Fb9xFend5UF2TAx+5M6+siseRDVEAVGYUodjBAMRg@mail.gmail.com>
In-Reply-To: <20180929185539.4144-2-ischis2@cox.net>

On Sat, Sep 29, 2018 at 2:55 PM Stephen P. Smith <ischis2@cox.net> wrote:
> Status variables were initialized in the collect phase and some
> variables were later freed in the print functions.
>
> A "struct wt_status" used to be sufficient for the output phase to
> work.  It was designed to be filled in the collect phase and consumed
> in the output phase, but over time some fields were added and output
> phase started filling the fields.
>
> A "struct wt_status_state" that was used in other codepaths turned out
> to be useful in the "git status" output.  This is not tied to "struct
> wt_status", so filling in the collect phase was not consistently
> followed.
>
> Move the status state structure variables into the status state
> structure and populate them in the collect functions.
>
> Create a new funciton to free the buffers that were being freed in the

s/funciton/function/

> print function.  Call this new function in commit.c where both the
> collect and print functions were being called.
>
> Signed-off-by: Stephen P. Smith <ischis2@cox.net>