From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 15 Jan 2018 09:58:29 GMT
Subject: Re: [PATCH 1/1] Mark messages for translations
Message-ID: <CAPig+cTm=bNqncS63DmN6Qi7GGkXcPv-wnKfNe=btgSM9YTPYg@mail.gmail.com>
In-Reply-To: <20180115054419.4112-2-ash@kambanaria.org>

On Mon, Jan 15, 2018 at 12:44 AM, Alexander Shopov <ash@kambanaria.org> wrote:
> Reuse already translated messages if possible
> Do not translate messages aimed at developers of git

A couple comments beyond those from Hannes...

> Signed-off-by: Alexander Shopov <ash@kambanaria.org>
> ---
> diff --git a/git.c b/git.c
> @@ -5,11 +5,11 @@
>  const char git_usage_string[] =
> +       N_("git [--version] [--help] [-C <path>] [-c name=value]\n"

Since you're touching this, perhaps take the opportunity to fix `-c
name=value` to say `-c <name>=<value>`?

> +          "           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]\n"
> +          "           [-p | --paginate | --no-pager] [--no-replace-objects] [--bare]\n"
> +          "           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]\n"
> +          "           <command> [<args>]");
> diff --git a/setup.c b/setup.c
> @@ -525,19 +525,19 @@ void read_gitfile_error_die(int error_code, const char *path, const char *dir)
>         case READ_GITFILE_ERR_NOT_A_REPO:
> -               die("Not a git repository: %s", dir);
> +               die(_("Not a git repository: %s"), dir);
>         default:
> -               die("BUG: unknown error code");
> +               die(_("BUG: unknown error code"));

This last one is aimed at developers (indeed, "BUG" message should
never been seen by end-users). I'd leave it untranslated.

>         }
>  }