From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 27 Jun 2019 04:50:28 GMT
Subject: Re: [RFC PATCH v2 02/13] walken: add usage to enable -h
Message-ID: <CAPig+cTk9=sd7iqwDT=ynRuAvyh3gj3NKQwkv9_tBo1v28Xysw@mail.gmail.com>
In-Reply-To: <20190626235032.177551-3-emilyshaffer@google.com>

On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer <emilyshaffer@google.com> wrote:
> It's expected that Git commands support '-h' in order to provide a
> consistent user experience (and this expectation is enforced by the
> test suite). '-h' is captured by parse_options() by default; in order to
> support this flag, we add a short usage text to walken.c and invoke
> parse_options().
> [...]
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> ---
> diff --git a/builtin/walken.c b/builtin/walken.c
> @@ -5,9 +5,34 @@
>  int cmd_walken(int argc, const char **argv, const char *prefix)
>  {
> +       [...]
> +       /*
> +        * This line is "human-readable" and we are writing a plumbing command,
> +        * so we localize it and use the trace library to print only when
> +        * the GIT_TRACE environment variable is set.
> +        */
>         trace_printf(_("cmd_walken incoming...\n"));

Also, this in-code comment should have been introduced in patch 1/13,
not here in 2/13.