From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 12 Mar 2013 23:13:02 GMT
Subject: Re: [PATCH v3 09/13] exclude: filter out patterns not applicable to the current directory
Message-ID: <CAPig+cTjmEVpr7gK4wp_+mvO9AHUenvpzGAy2wGht=HB+quvLQ@mail.gmail.com>
In-Reply-To: <1363093500-16796-10-git-send-email-pclouds@gmail.com>

On Tue, Mar 12, 2013 at 9:04 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> The algorithm implemented here is a naive one. Patterns can be either
> active or passive:
>
>  - When we enter a new directory (e.g. from root to foo), currently
>    active patterns may no longer be applicable and can be turned to
>    passive.
>
>  - On the opposite, when we leave a directory (foo back to roo),

s/roo/root/

Also, perhaps you meant s/On/Or/ ?

> +/*
> + * If pushed is non-zero, we have entered a new directory. Some
> + * pathname patterns may no longer applicable. Go over all active

s/applicable/be applicable/

-- ES