From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 14 Mar 2016 21:32:59 GMT
Subject: Re: [PATCH v6] commit: add a commit.verbose config variable
Message-ID: <CAPig+cTj0AeAUPDm2MBE=72b98AU+0F90a6UwmorwrRoO0kx_A@mail.gmail.com>
In-Reply-To: <CAPig+cRC5kZCtELhTh3em0bv+mfeR58AKd3Y76VM+0J+C+zzcw@mail.gmail.com>

On Mon, Mar 14, 2016 at 5:21 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> This is missing the important "-c commit.verbose=false". Without it,

I meant "-c commit.verbose=true", of course.

> you're not really testing anything interesting.
>
> (It was missing in the "something like this" example test I typed
> directly in the email of my last review[1], which I suppose is a good
> lesson that "something like this" is not meant as "final" or "trust
> this".)