From: Eric Sunshine Date: Thu, 06 Aug 2020 16:17:07 GMT Subject: Re: [PATCH 3/3] mergetool-lib: give kdiff3 prioirty in KDE environments Message-ID: In-Reply-To: On Thu, Aug 6, 2020 at 8:37 AM Marco Trevisan (Treviño) wrote: > Il giorno mer 5 ago 2020 alle ore 23:16 Eric Sunshine > ha scritto: > > Wouldn't this change the behavior for people running old KDE which > > doesn't have XDG_CURRENT_DESKTOP, giving "kdiff3" much lower priority > > than it had before? > > Yeah, true.. So to avoid this we can just also check for > KDE_FULL_SESSION, that has been introduced by KDE 3.2, and this should > be enough I think. I'm not a user of git-mergetool or KDE, so I can't speak as an end-user. My comment was made merely as a reviewer of the code. If it is easy to avoid the behavior change by also checking KDE_FULL_SESSION in addition to the new check of XDG_CURRENT_DESKTOP without it being a maintenance burden, then that sounds like a good choice. On the other hand, if there wasn't a good way to avoid changing behavior for users of older KDE, then explaining that in the commit message would be expected.