From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 13 Apr 2016 06:14:23 GMT
Subject: Re: [PATCH v14 6/6] commit: add a commit.verbose config variable
Message-ID: <CAPig+cTcCyGu5Y8aHbE3i6fXh3T_mD0ZiuxPFh=DVHOE38pE5w@mail.gmail.com>
In-Reply-To: <010201540cb60966-e9711378-3b22-4fbb-a2c7-f6876a6fb3c6-000000@eu-west-1.amazonses.com>

On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
> Add commit.verbose configuration variable as a convenience for those
> who always prefer --verbose.
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
> ---
> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
> @@ -98,4 +98,60 @@ test_expect_success 'verbose diff is stripped out with set core.commentChar' '
> +test_expect_success 'status ignores commit.verbose=true' '
> +       git -c commit.verbose=true status >actual &&
> +       ! grep "^diff --git" actual
> +'

I understand what this test is checking, as it is in response to
Junio's suggestion[1]...

> +test_expect_success 'status does not verbose without --verbose' '
> +       git status >actual &&
> +       ! grep "^diff --git" actual
> +'

But what is this test checking?

> +
>  test_done

[1]: http://article.gmane.org/gmane.comp.version-control.git/288648