From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 10 May 2016 02:49:06 GMT
Subject: Re: [PATCH v2] t6302: simplify non-gpg cases
Message-ID: <CAPig+cTa-7-cneOaFgtUnXPFbMZZA3b5m-3kJK2=qB5ASRmCqg@mail.gmail.com>
In-Reply-To: <20160510024032.GA16965@sigill.intra.peff.net>

On Mon, May 9, 2016 at 10:40 PM, Jeff King <peff@peff.net> wrote:
> On Mon, May 09, 2016 at 01:47:35PM -0400, Eric Sunshine wrote:
>> > -       test_prepare_expect <<-\EOF | sed -e "s/Z$//" >expect &&
>> > +       cat <<-\EOF | sed -e "s/Z$//" >expect &&
>>
>> To make this as close to a reversion as possible, this could be
>> restored to the original (sans 'cat'):
>>
>>     sed -e "s/Z$//" >expect <<-\EOF &&
>
> Thanks, I did the reversion with s/test_prepare_expect/cat/ rather than
> reverting 618310a, but I agree dropping this useless-use-of-cat is worth
> doing. Here's v2 with that change and your reviewed-by.

Looks good, thanks.