From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 31 Jan 2024 17:55:22 GMT
Subject: Re: [PATCH 7/9] reftable/merged: refactor seeking of records
Message-ID: <CAPig+cTZcxiZUPgjqEzMNG72X4fwnNT_DwjTj5cQh5zEpiN2Hw@mail.gmail.com>
In-Reply-To: <00aeaeee63dc1371d3338b72f779c6f165bd14f7.1706687982.git.ps@pks.im>

On Wed, Jan 31, 2024 at 3:02 AM Patrick Steinhardt <ps@pks.im> wrote:
> The code to seek reftable records in the merged table code is quite hard
> to read and does not conform to our coding style in multiple ways:
>
>   - We have multiple exit paths where we release resources even though
>     that is not really necessary

s/$/./

>   - We use a scoped error variable `e` which is hard to reason about.
>     This variable is not required at all.
>
>   - We allocate memory in the variable declarations, which is easy to
>     miss.
>
> Refactor the function so that it becomes more maintainable in the
> future.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>