From: Eric Sunshine Date: Tue, 18 Jun 2013 04:16:32 GMT Subject: Re: [PATCH v2 06/13] bash prompt: run 'git rev-parse --git-dir' directly instead of __gitdir() Message-ID: In-Reply-To: <1371521826-3225-7-git-send-email-szeder@ira.uka.de> On Mon, Jun 17, 2013 at 10:16 PM, SZEDER Gábor wrote: > From: SZEDER Gábor > > __git_ps1() finds out the path to the repository by using the > __gitdir() helper function. __gitdir() is basically just a wrapper > around 'git rev-parse --git-dir', extended with support for > recognizing a remote repository given as argument, to use the path > given on the command line, and with a few shortcuts to recognize a git > repository in cwd or at $GIT_DIR quickly without actually running 'git > rev-parse'. However, the former two is only necessary for the > completion script but makes no sense for the bash prompt, while the > latter shortcuts are performance optimizations __git_ps1() can do > without (they just avoid the overhead of fork()+exec()ing a git > process). > > Run 'git rev-parse --git-dir' directly in __git_ps1(), because it will > allow this patch series to combine several $(git rev-parse ...) > command substitutions in the main code path, and the overall > performance benefit will far outweight the loss of those few shortcuts s/outweight/outweigh/ > in __gitdir(). Furthermore, since __gitdir() is not needed anymore > for the prompt, remove it from the prompt script finally eliminating > its duplication between the prompt and completion scripts. Also > remove the comment from the completion script warning about this code > duplication. > > Signed-off-by: SZEDER Gábor