From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 14 Dec 2020 19:56:19 GMT
Subject: Re: [PATCH v2 2/2] refs: warn on non-pseudoref looking .git/<file> refs
Message-ID: <CAPig+cTWoBaoQxNvbFhKNVSvYP_TFOqdfLsu5tOW32uO5TEoaQ@mail.gmail.com>
In-Reply-To: <20201214191700.16405-3-avarab@gmail.com>

On Mon, Dec 14, 2020 at 2:17 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> [...]
> Our own test suite makes use of a few refs in .git/ that aren't
> produced by git itself, e.g. "FOO", "TESTSYMREFTWO" etc. External
> tools probably rely on this as well, so I don't think it's viable to
> e.g. have a whitelist of them. That list is quite large just fr

You want a s/fr/from/ here or something?

> git.git, I counted 12 names used in the C code before I abandoned that
> approach.
> [...]
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Modified-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Is the Modified-by: footer intentional?