From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 23 Feb 2021 16:21:46 GMT
Subject: Re: [PATCH] maintenance: fix incorrect `maintenance.repo` path with bare repository
Message-ID: <CAPig+cTWZSe+e5JnTLMDt+F7NxdLG0fFqqSavkyo_YN7B7Affg@mail.gmail.com>
In-Reply-To: <5653230a-20c2-321f-7ea0-93ce59858532@gmail.com>

On Tue, Feb 23, 2021 at 7:26 AM Derrick Stolee <stolee@gmail.com> wrote:
> On 2/23/2021 2:31 AM, Eric Sunshine wrote:
> > +test_expect_success 'register and unregister bare repo' '
> > +     test_when_finished "git config --global --unset-all maintenance.repo || :" &&
> > +     test_might_fail git config --global --unset-all maintenance.repo &&
> > +     git init --bare barerepo &&
> > +     (
> > +             cd barerepo &&
> > +             git maintenance register &&
> > +             git config --get --global --fixed-value maintenance.repo "$(pwd)" &&
>
> I'm concerned about this test passing on Windows, but if the CI build is happy,
> then I'm happy.

I had a slight worry about Windows, as well, but (1) this is copied
directly from an earlier test in this script which does pass on
Windows, and (2) I tested on Windows, and it works fine. So, all is
good.

> Reviewed-by: Derrick Stolee <dstolee@microsoft.com>

Thanks.