From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 18 Sep 2020 17:08:05 GMT
Subject: Re: [PATCH 4/4] hooks--update.sample: use hash-agnostic null OID
Message-ID: <CAPig+cTVwOiB2OB1oHCsBn_DNMncDpiD0Pi-tuaUmKyMf9qEEw@mail.gmail.com>
In-Reply-To: <42d282988961545fb1ab6405a08368d14ffa1450.1600427894.git.liu.denton@gmail.com>

On Fri, Sep 18, 2020 at 7:19 AM Denton Liu <liu.denton@gmail.com> wrote:
> The update sample hook has the null OID hardcoded as 40 zeros. However,
> with the introduction of SHA-256 support, this assumption no longer
> holds true. Replace the hardcoded $z40 with a call to
> `git rev-parse --null-oid` so the sample hook becomes hash-agnostic.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> diff --git a/templates/hooks--update.sample b/templates/hooks--update.sample
> @@ -60,7 +60,7 @@ esac
> -zero="0000000000000000000000000000000000000000"
> +zero="$(git rev-list --null-oid)"

Definitely want a s/rev-list/rev-parse/ here.