From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 06 Feb 2023 18:14:50 GMT
Subject: Re: [PATCH 2/2] diff: teach diff to read gitattribute diff-algorithm
Message-ID: <CAPig+cTTfsP-hTSd=1QF-zZ9WNpHMgO-+18PTmnggz4SANfmMg@mail.gmail.com>
In-Reply-To: <19f6b40b-d8e8-e86c-5a9a-b35f42909118@dunelm.org.uk>

On Mon, Feb 6, 2023 at 11:46 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
> On 05/02/2023 03:46, John Cai via GitGitGadget wrote:
> > Teach the diff machinery to check attributes for a diff algorithm.
> > Enforce precedence by favoring the command line option, then looking at
> > attributes, then finally the config.
> >
> > To enforce precedence order, set the `xdl_opts_command_line` member
> > during options pasing to indicate the diff algorithm was set via command
> > line args.
>
> I've only commented on the tests as it looks like Eric and had a careful
> look at the code

I only very quickly ran my eye over the code; didn't even really read it.