From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 10 Mar 2025 23:53:28 GMT
Subject: Re: [PATCH v1 1/4] t: introduce WITH_BREAKING_CHANGES prerequisite
Message-ID: <CAPig+cTRNts9JO-17rfkmmwyTJojJSv-mS1kvxCJV+L2F2WgzA@mail.gmail.com>
In-Reply-To: <20250310231652.3742490-2-gitster@pobox.com>

On Mon, Mar 10, 2025 at 7:17 PM Junio C Hamano <gitster@pobox.com> wrote:
> Earlier c5bc9a7f (Makefile: wire up build option for deprecated
> features, 2025-01-22) made an unfortunate decision to introduce the
> WITHOUT_BREAKING_CHANGES prerequisite to perform tests that ensure
> the historical behaviour that may be different from what we will
> have in the future.  It would inevitably invite doulbe negation when
> we need to add tests to ensure the behaviour we want to have in the
> future.

s/doulbe/double/

> Introduce WITH_BREAKING_CHANGES prerequisite and replace the
> existing uses of WITHOUT_BREAKING_CHANGES prerequisite.  Some
> in-flight topics that add more uses of WITHOUT_BREAKING_CHANGES
> would still need the old prerequisite, so let's keep its definition
> for now while we'll eradicate its use.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>