From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 27 May 2014 06:10:48 GMT
Subject: Re: [PATCH v3 2/5] commit test: Change $PWD to $(pwd)
Message-ID: <CAPig+cTRF5NFUagF6mLbBduJe8TgACTHdc7CbK_QRehZ-2DXqw@mail.gmail.com>
In-Reply-To: <538426D3.8090107@viscovery.net>

On Tue, May 27, 2014 at 1:46 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Am 5/26/2014 20:56, schrieb Caleb Thompson:
>> Signed-off-by: Caleb Thompson <caleb@calebthompson.io>
>> ---
>>  t/t7507-commit-verbose.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
>> index 6d778ed..3b06d73 100755
>> --- a/t/t7507-commit-verbose.sh
>> +++ b/t/t7507-commit-verbose.sh
>> @@ -8,7 +8,7 @@ cat >check-for-diff <<EOF
>>  exec grep '^diff --git' "\$1"
>>  EOF
>>  chmod +x check-for-diff
>> -test_set_editor "$PWD/check-for-diff"
>> +test_set_editor "$(pwd)/check-for-diff"
>>
>>  cat >message <<'EOF'
>>  subject
>
> Why? I see no benefit. Both $PWD and $(pwd) work fine everywhere,
> including Windows, and the former is faster, particularly on Windows.

Poor advice on my part when reviewing the previous round. When I had
read in git/t/README (in the distant past):

    When a test checks for an absolute path that a git command
    generated, construct the expected value using $(pwd) rather than
    $PWD, $TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference
    on Windows, where the shell (MSYS bash) mangles absolute path
    names.  For details, see the commit message of 4114156ae9.

I must have missed the word "check" in the first sentence.