From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sat, 04 Jun 2016 00:02:25 GMT
Subject: Re: [PATCH 1/3] pretty: support "mboxrd" output format
Message-ID: <CAPig+cTQkEb6K95aeJ9vNyJ=S+8x+JnCQAYSEzydXKzbq-+Yyg@mail.gmail.com>
In-Reply-To: <xmqqzir1zvo2.fsf@gitster.mtv.corp.google.com>

On Fri, Jun 3, 2016 at 7:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>>>         static int is_mboxrd_from(const char *line) {
>>>                 return starts_with(line + strspn(line, ">"), "From ");
>>>         }
>>>
>>> is sufficiently high-level that no longer is scary, hopefully?
>>
>> That's nice and concise but unfortunately not useful for this case
>> where we must respect the logical end-of-line (within the larger
>> buffer), represented by line+linelen.
>
> Hmph, none of ">", "F", "r", "o", "m", or " " is "\n"; would eol
> still be an issue?

Ah right. Sorry for being slow.

Your concise version of is_mboxrd_from() is a nice alternative, as well.