From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 08 Apr 2018 01:06:08 GMT
Subject: Re: [PATCH v11 1/4] ref-filter: use "struct object_id" consistently
Message-ID: <CAPig+cTQ1ZzWTp6Qsj96nE8QwhuRuqB51orTNsCQjGKD=_veyg@mail.gmail.com>
In-Reply-To: <20180407164250.54303-1-haraldnordgren@gmail.com>

On Sat, Apr 7, 2018 at 12:42 PM, Harald Nordgren
<haraldnordgren@gmail.com> wrote:
> From: Jeff King <peff@peff.net>
>
> Internally we store a "struct object_id", and all of our
> callers have one to pass us. But we insist that they peel it
> to its bare-sha1 hash, which we then hashcpy() into place.
> Let's pass it around as an object_id, which future-proofs us
> for a post-sha1 world.
> ---

You incorrectly dropped Peff's sign-off[1] when re-sending the patches
he authored in the series. And, your sign-off should follow his.

Also, if you made any changes to Peff's patch, it's a good idea to
state so with a bracketed comment at the end of the commit message
(before the sign-offs). For instance:

    [hn: tweaked doodle blap]

or such.

[1]: https://public-inbox.org/git/20180406185831.GA11108@sigill.intra.peff.net/