From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 02 Apr 2019 05:50:43 GMT
Subject: Re: [PATCH v2 2/4] progress: assemble percentage and counters in a strbuf before printing
Message-ID: <CAPig+cTOOthnjweyRjJuLy6o2TffPwTPJmQ_5tJoP1jhdKyD6g@mail.gmail.com>
In-Reply-To: <CAPig+cRMBmfG1YDeP9t9eLZdqMqthfxp6nviQYGr7qNEA2U54Q@mail.gmail.com>

On Tue, Apr 2, 2019 at 1:45 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Mon, Apr 1, 2019 at 7:52 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
> > +       if (show_update) {
> >                 [...]
> >                 progress_update = 0;
> > -               return;
> >         }
>
> Removal of these two 'returns' is unrelated to the change made by this
> patch and should have been done by 1/4.
>
> >         return;
>
> Likewise, this final 'return' doesn't need to be here and should go away in 1/4.

I forgot to mention that these are micro-nits, not necessarily worth a re-roll.