From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 25 Mar 2016 08:44:18 GMT
Subject: Re: [PATCH v10 2/2] pull --rebase: add --[no-]autostash flag
Message-ID: <CAPig+cTH-3PqZFyP_R1FyTPKhRhbbLRDeYfv2TcVq=gq=ZpRcQ@mail.gmail.com>
In-Reply-To: <CAPig+cSdegoGNCMBMcHyEYiE+LUzixvdk-qu0Q-zbFvatX2=KA@mail.gmail.com>

On Fri, Mar 25, 2016 at 4:31 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>     for i in --autostash --no-autostash
>     do
>         test_expect_success "pull $i (without --rebase) is illegal" "
>            test_must_fail git pull $i . copy 2>actual &&
>            test_i18ngrep 'only valid with --rebase' actual
>         "
>     done
>
> Take special note of how use of double (") and single (') quotes
> differ in this case from other tests since $i needs to be interpolated
> into the test body.

That's not accurate. Since $i will be visible when the test body is
actually evaluated, it will work correctly even with the body
single-quoted as usual (like all other tests), so swapping the quotes
around like this is unnecessary (and Junio would prefer[1] they not be
swapped).

[1]: http://article.gmane.org/gmane.comp.version-control.git/284769