From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 03 Sep 2018 19:06:54 GMT
Subject: Re: [GSoC][PATCH v8 17/20] stash: convert save to builtin
Message-ID: <CAPig+cTGBi1P5V3uGwtKCvoCn=-17y1dY3dBkS13Yx1ikjpXcQ@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1809032031090.71@tvgsbejvaqbjf.bet>

On Mon, Sep 3, 2018 at 2:44 PM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> where `strbuf_join_argv()` would be implemented like this (and I would put
> it into strbuf.c and strbuf.h:
>
>         const char *strbuf_join_argv(struct strbuf *buf,
>                                      int argc, const char **argv, char delim)
>         {
>                 if (!argc)
>                         return buf->buf;
>
>                 strbuf_addstr(buf, *argv);
>                 while (--i) {

s/i/argc/

>                         strbuf_addch(buf, delim);
>                         strbuf_addstr(buf, *(++argv);
>                 }
>
>                 return buf->buf;
>         }