From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 26 Jul 2020 23:54:54 GMT
Subject: Re: [PATCH v4 37/39] ci: run tests with SHA-256
Message-ID: <CAPig+cTD6yjqj9Mpte2zdFNXhJSk9Ju01SZYyptBCsSb9cxakA@mail.gmail.com>
In-Reply-To: <20200726195424.626969-38-sandals@crustytoothpaste.net>

On Sun, Jul 26, 2020 at 3:56 PM brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> Now that we have Git supporting SHA-256, we'd like to make sure that we
> don't regress that state.  Unfortunately, it's easy to do so, so to
> help, let's add code to run one of our CI jobs with SHA-256 as the
> default hash.  This will help us detect any problems that may occur.
>
> We pick the linux-clang job because it's relatively fast and the
> linux-gcc job already runs the testsuite twice.  We want our tests to
> run as fast as possible, so we wouldn't want to add a third run to the
> linux-gcc job.  To make sure we properly exercise the code, let's run
> the tests in the default mode (SHA-1) first and then run a second time
> with SHA-256.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
> @@ -24,6 +24,11 @@ linux-gcc)
> +linux-clang)
> +       make test
> +       export GIT_TEST_DEFAULT_HASH=sha256
> +       make test
> +       ;;

If the default someday flips from sha1 to sha256, then this will
merely run the entire test suite twice with SHA-256. Perhaps it could
be more explicit like this:

    export GIT_TEST_DEFAULT_HASH=sha1
    make test
    export GIT_TEST_DEFAULT_HASH=sha256
    make test