From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 29 Feb 2016 23:37:40 GMT
Subject: Re: What's cooking in git.git (Feb 2016, #07; Thu, 25)
Message-ID: <CAPig+cTAv8eNcTkN6K1kJ5zBcibmbRR59MLV6PCM=qa84HNdDg@mail.gmail.com>
In-Reply-To: <xmqq37sbe8qr.fsf@gitster.mtv.corp.google.com>

On Mon, Feb 29, 2016 at 12:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>>> Your suggestion elsewhere in the thread to just use clang instead sounds
>>> good to me. :)
>>
>> If possible, for the moment, I'd prefer to hold off on that
>> sledge-hammer approach of unconditionally making the build use clang.
>> It would be nice to have a more detailed understanding of what exactly
>> is triggering the Apple compiler bug, and I've been trying to find
>> time to check it out on my old Mac.
>
> The (fixed) patch posted was "on OSX 10.6, use clang by default"; I
> think that for majority of the users, that is a reasonable thing to do.
>
> The result of the patch still allows those who want to see how badly
> old Gcc breaks to do so with "make CC=gcc", doesn't it?

I was not able to reproduce the problem on OSX 10.5.8.

Since the patch applies specifically to 10.6 (via -eq) rather than
"10.6 and earlier" (via -le) it happily does not break the build for
older OSX releases (such as 10.5.8) which lack clang. Thanks.