From: Eric Sunshine Date: Wed, 18 Jul 2018 19:55:38 GMT Subject: Re: [PATCH v2 0/6] git-submodule.sh: convert part of cmd_update to C Message-ID: In-Reply-To: On Wed, Jul 18, 2018 at 3:34 PM Stefan Beller wrote: > On Tue, Jul 17, 2018 at 11:59 AM Eric Sunshine wrote: > > The "git-format-patch --range-diff" option implemented by that patch > > series (and its upcoming re-roll) place the range-diff before the "-- > > " signature line, so this isn't a problem. > > Now that I grow more accustomed to range-diffs, I wonder > if we want to have them even *before* the short stat in the > cover letter. (I usually scroll over the short stat just to take it > as a FYI on what to expect, whereas the range-diff can already > be reviewed, hence seems more useful that the stats) I did consider placing the range-diff before the diffstat, however, what convinced me to position range-diff last was that the diffstat is usually short and easy to skip over both visually and via scrolling, whereas the range-diff often is long and noisy, thus more difficult to skip for someone more interested in the diffstat. So, the choice was deliberate. However, I also considered making it configurable, but that's probably something that can be done later, if needed, once we get more experience with the feature. It's also worth taking Duy's wish[1] for customization into account, as well, before designing such capability. [1]: https://public-inbox.org/git/CACsJy8D=6fAEpO5m4cc7KZyggAW1AosSkUWaunQBFH0nr-YrdA@mail.gmail.com/