From: Eric Sunshine Date: Wed, 10 Dec 2014 09:49:38 GMT Subject: Re: [PATCH v3] pkt-line: allow writing of LARGE_PACKET_MAX buffers Message-ID: In-Reply-To: On Wed, Dec 10, 2014 at 4:42 AM, Eric Sunshine wrote: > On Wed, Dec 10, 2014 at 3:36 AM, Eric Sunshine wrote: >> On Wed, Dec 10, 2014 at 2:34 AM, Jeff King wrote: >>> Below is a another iteration on the patch. The actual code changes are >>> the same as the strbuf one, but the tests take care to avoid assuming >>> the filesystem can handle such a long path. Testing on Windows and OS X >>> is appreciated. >> >> All three new tests fail on OS X. Thus far brief examination of the >> first failing tests shows that 'expect' and 'actual' differ: >> >> expect: >> long >> master >> >> actual: >> master > > The failure manifests as soon as the refname hits length 1024, at > which point for-each-ref stops reporting it. MAX_PATH on OS X is 1024, > so some part of the machinery invoked by for-each-ref likely is > rejecting refnames longer than that (even when coming from > packed-refs). Clarification: for-each-ref ignores the ref when the full line read from packed-refs hits length 1024 (not when the refname itself hits length 1024).