From: Eric Sunshine Date: Mon, 21 Jun 2021 20:02:37 GMT Subject: Re: [PATCH] bisect: allow to run from subdirectories Message-ID: In-Reply-To: <87sg1b2xhl.fsf@evledraar.gmail.com> On Mon, Jun 21, 2021 at 8:50 AM Ævar Arnfjörð Bjarmason wrote: > On Mon, Jun 21 2021, Roland Hieber wrote: > > On Sun, Jun 20, 2021 at 10:10:10PM -0400, Eric Sunshine wrote: > >> There have been multiple patches sent to the project over the years > >> with the same purpose. One problem, I believe, which has never been > >> fully addressed is what happens when the subdirectory from which > >> git-bisect is run gets deleted as part of the bisection. > > > > Ah, thanks for explaining the problem. Would a patch that adds a short > > explanatory comment in git-bisect.sh on the matter help to prevent > > people sending such patches? > > Having skimmed the linked discussions I don't think the consensus is > that this shouldn't exist, but that someone who wants it should do some > research on the relevant edge cases, come up with test cases for them, > discuss the trade-offs in a commit message etc. Be that as it may, having a comment in the code explaining why it is currently turned off and what needs to be accomplished before turning it on might indeed be a good way to stem the flow of patches which merely flip-the-switch without doing that extra research. Whether or not Junio would accept such a patch documenting the current state of affairs is a different question.