From: Eric Sunshine Date: Mon, 17 Aug 2020 17:16:40 GMT Subject: Re: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable. Message-ID: In-Reply-To: <20200817125419.1655-1-vvavrychuk@gmail.com> On Mon, Aug 17, 2020 at 8:54 AM Vasyl Vavrychuk wrote: > Looks like Google changed gmail security and now less secure app access > needs to be explicitly enabled if 2-factor authentication is not in > place, otherwise send-mail fails with: > > 5.7.8 Username and Password not accepted. Learn more at > 5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp > --- Missing sign-off. Please see Documentation/SubmittingPatches. > diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt > @@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings: > +If you do not have multifactor authentication setup on your gmail account, you > +need to allow less secure app access. Visit > +https://myaccount.google.com/lesssecureapps to enable it. Thanks. Make sense. A few comments: I think multi-factor is usually hyphenated, so perhaps: s/multifactor/multi-factor/ Since you are not using it as a noun: s/setup/set up/ Also, Gmail is normally capitalized, so: s/gmail/Gmail > @@ -505,7 +509,7 @@ following commands: > -The first time you run it, you will be prompted for your credentials. Enter the > +The first time you run it, you will be prompted for your credentials. Enter the This unnecessary whitespace change just adds noise to the patch, thus should be dropped.