From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 04 Nov 2020 17:03:22 GMT
Subject: Re: [PATCH 2/3] format-patch: tie file-opening logic to output_directory
Message-ID: <CAPig+cT8BTTwcORWB1zNWFy8DaohyibWFxojDiU-Na933abRqA@mail.gmail.com>
In-Reply-To: <20201104132737.GB3030146@coredump.intra.peff.net>

On Wed, Nov 4, 2020 at 8:27 AM Jeff King <peff@peff.net> wrote:
> In format-patch we're either outputting to stdout or to individual files
> in an output directory (which maybe just "./"). Our logic for whether to

s/maybe/may be/

> open a new file for each patch is checked with "!use_stdout", but it is
> equally correct to check for a non-NULL output_directory.
>
> The distinction will matter when we add a new single-stream output in a
> future patch, when only one of the three methods will want individual
> files. Let's swap the logic here in preparation.
>
> Signed-off-by: Jeff King <peff@peff.net>