From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 24 Aug 2016 07:28:44 GMT
Subject: Re: [PATCH 09/15] sequencer: lib'ify create_seq_dir()
Message-ID: <CAPig+cT7fNsyhk1J0Z6evk8xRxa=g8ygUniBB+EHSRMRFcNLcQ@mail.gmail.com>
In-Reply-To: <80062be27256704617280fdb479176e0d2afb4d4.1471968378.git.johannes.schindelin@gmx.de>

On Tue, Aug 23, 2016 at 12:07 PM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:
> To be truly useful, the sequencer should never die() but always return
> an error.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> diff --git a/sequencer.c b/sequencer.c
> @@ -839,8 +839,8 @@ static int create_seq_dir(void)
>                 return -1;
>         }
>         else if (mkdir(git_path_seq_dir(), 0777) < 0)
> -               die_errno(_("Could not create sequencer directory %s"),
> -                         git_path_seq_dir());
> +               return error(_("Could not create sequencer directory %s (%s)"),
> +                         git_path_seq_dir(), strerror(errno));

error_errno()?

>         return 0;
>  }