From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 18 Jul 2019 16:29:42 GMT
Subject: Re: [PATCH v2] transport-helper: enforce atomic in push_refs_with_push
Message-ID: <CAPig+cT5nbXcsj+CH38FwfE0m+S6VffG_Zz8iz0zpw49zDwd+Q@mail.gmail.com>
In-Reply-To: <20190718152234.GI20404@szeder.dev>

On Thu, Jul 18, 2019 at 11:22 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
> C99 'for' loop initial declaration, i.e. 'for (int i = 0; i < n; i++)',
> is not allowed in Git's codebase yet, to maintain compatibility with
> some older compilers.
> [...]
> [1] The Azure Pipelines builds have been using Ubuntu 16.04 images
>     from the start, so I belive they never caught 'for' loop initial
>     declarations.

s/belive/believe/

> [2] On Travis CI 'make test' alone would take about 9 minutes in this
>     new job (without running httpd, Subversion, and P4 tests).  For
>     comparison, starting the job and building Git with GCC 4.8 takes
>     only about 2 minutes.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>