From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 27 Oct 2025 00:24:57 GMT
Subject: Re: [PATCH v3 2/2] repo: add --all to git-repo-info
Message-ID: <CAPig+cT3hkBu2kKPQp74JKvO7ct5ooV1wba8xHTzOn_9FGbz7A@mail.gmail.com>
In-Reply-To: <CAPig+cSOE1Du52Y8-s=b7HvKQyk-XHdGh3XzZR_tVktut9R1YA@mail.gmail.com>

On Sun, Oct 26, 2025 at 8:22 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sun, Oct 26, 2025 at 6:54 PM Lucas Seiki Oshiro
> <lucasseikioshiro@gmail.com> wrote:
> > +       for (unsigned long i = 0; i < ARRAY_SIZE(repo_info_fields); i++) {
> > +               struct field field = repo_info_fields[i];
>
> Why do we need to make a copy of the field record? Can't we just use a
> const pointer?
>
>     struct field *field = &repo_info_fields[i];
>
> or:
>
>    struct field *field = repo_info_fields + i;

Of course, I mean to have a `const` in there:

    const struct field *field = &repo_info_fields[i];