From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sat, 21 Oct 2017 10:49:15 GMT
Subject: Re: [PATCH 4/4] worktree: handle broken symrefs in find_shared_symref()
Message-ID: <CAPig+cT3=BNcM+WZWhpAq6Ch=5xC47oW_S-9=YfEQL7rRkyPhw@mail.gmail.com>
In-Reply-To: <20171019174936.izojvrh5w35s3adi@sigill.intra.peff.net>

On Thu, Oct 19, 2017 at 1:49 PM, Jeff King <peff@peff.net> wrote:
> The refs_resolve_ref_unsafe() function may return NULL even
> with a REF_ISSYMREF flag if a symref points to a broken ref.
> As a result, it's possible for find_shared_symref() to
> segfault when it passes NULL to strcmp().
> [...]
> We can fix this by treating NULL the same as a non-matching
> symref. Arguably we'd prefer to tell know if a symref points

s/tell//

> to "refs/heads/foo", but "refs/heads/foo" is broken. But
> refs_resolve_ref_unsafe() isn't capable of giving us that
> information, so this is the best we can do.
>
> Signed-off-by: Jeff King <peff@peff.net>