From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 28 Sep 2022 23:35:31 GMT
Subject: Re: [PATCH v2 02/35] builtin/bundle.c: use \t, not fix indentation 2-SP indentation
Message-ID: <CAPig+cT+-bT0FUVYaGnMqwbAYasJPp2Ci+gC8=qRPf7vpxj=gQ@mail.gmail.com>
In-Reply-To: <patch-v2-02.35-63145b58504-20220928T082458Z-avarab@gmail.com>

On Wed, Sep 28, 2022 at 4:41 AM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> builtin/bundle.c: use \t, not fix indentation 2-SP indentation

Not worth a reroll, but doesn't this have one to many instances of
"indentation"? Also: s/fix/fixed/ ?

I'd probably have written it simply as:

    builtin/bundle.c: indent with tabs

> Fix indentation issues introduced with 73c3253d75e (bundle: framework
> for options before bundle file, 2019-11-10), and carried forward in
> some subsequent commits.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

The patch itself makes sense.