From: Eric Sunshine Date: Sun, 02 May 2021 23:19:37 GMT Subject: Re: [gitgitgadget/git] git-merge: rewrite already up to date message (#934) Message-ID: In-Reply-To: On Sun, May 2, 2021 at 2:52 AM Eric Sunshine wrote: > On Sun, May 2, 2021 at 1:49 AM Josh Soref wrote: > > Eric Sunshine wrote: > > > diff --git a/notes-merge.c b/notes-merge.c > > > - printf("Already up to date!\n"); > > > + printf_ln("Already up to date."); > > > > Should this have `_(...)` decorations? > > Yes, indeed. I'll fix it in a re-roll and mention it in the commit message. On second thought, I don't think I will make this change since none of the messages in `notes-merge.c` have been marked for localization yet -- and there are a lot of messages in that file -- so wrapping just this one message in `_(...)` would be inconsistent, and marking all messages in `notes-merge.c` as localizable is outside the scope of this series. So, at the moment, I don't plan on re-rolling this series, and hopefully Junio can pick it up as-is (but, of course, will re-roll if someone spots something which needs fixing).