From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 08 Aug 2018 09:51:13 GMT
Subject: Re: [PATCH v4 0/2] fix author-script quoting
Message-ID: <CAPig+cSyaxXv=a1s3nM2nGYj9D09iqgsfPD02o9cjEeWXFhR-A@mail.gmail.com>
In-Reply-To: <20180807093452.22524-1-phillip.wood@talktalk.net>

On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood <phillip.wood@talktalk.net> wrote:
> I've updated these based on Eric's suggestions, hopefully they're good
> to go now. Thanks Eric for you help.

Thanks, I left a few comments on patch 2/2. Aside from the '>' vs.
'>=' issue (over which I lost more than a few minutes cogitating), I
don't think there are any blockers this time around.

There are 2 or 3 things which can be done as follow-ups (indeed, even
the '>' vs. '>=' could be so), but I don't think any of them are so
critical that they need to be part of this series (for instance, the
strbuf leak in the error path has been around for some time, and can
be fixed later).