From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 28 Aug 2013 20:35:54 GMT
Subject: Re: [PATCH 1/8] remote-bzr: fix export of utf-8 authors
Message-ID: <CAPig+cSt6HCuB2VOj_-C+e7BeXJD72hKdtNN3ueyKn6B4DSu7A@mail.gmail.com>
In-Reply-To: <1377717793-27170-2-git-send-email-felipe.contreras@gmail.com>

On Wed, Aug 28, 2013 at 3:23 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Reported-by: Joakim Verona <joakim@verona.se>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  contrib/remote-helpers/git-remote-bzr |  1 +
>  contrib/remote-helpers/test-bzr.sh    | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 31 insertions(+)
>
> diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh
> index dce281f..ef8992a 100755
> --- a/contrib/remote-helpers/test-bzr.sh
> +++ b/contrib/remote-helpers/test-bzr.sh
> @@ -358,4 +358,34 @@ test_expect_success 'strip' '
>         test_cmp expected actual
>  '
>
> +test_expect_success 'export utf-8 authors' '
> +       test_when_finished "rm -rf bzrrepo gitrepo && LC_ALL=C && unset GIT_COMMITTER_NAME" &&
> +
> +       LC_ALL=en_US.UTF-8
> +       export LC_ALL
> +
> +       GIT_COMMITTER_NAME="Grégoire"
> +       export GIT_COMMITTER_NAME
> +
> +       bzr init bzrrepo &&
> +
> +       (
> +       git init gitrepo &&
> +       cd gitrepo &&
> +       echo greg >> content &&
> +       git add content &&
> +       git commit -m one

Broken &&-chain.

> +       git remote add bzr "bzr::../bzrrepo" &&
> +       git push bzr
> +       ) &&
> +
> +       (
> +       cd bzrrepo &&
> +       bzr log | grep "^committer: " > ../actual
> +       ) &&
> +
> +       echo "committer: Grégoire <committer@example.com>" > expected &&
> +       test_cmp expected actual
> +'
> +
>  test_done
> --