From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 08 Jun 2016 01:51:42 GMT
Subject: Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C
Message-ID: <CAPig+cSsgmu6dHDrqHybKMJiQ9bi29TqnJWq78=1r+pLyDR1kw@mail.gmail.com>
In-Reply-To: <CAPig+cTqk0d60Omsm12RXF2uzoxoPjbqHj7V8Y=6Uu+fH5b43Q@mail.gmail.com>

On Tue, Jun 7, 2016 at 6:31 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> +int bisect_clean_state(void)
>> +{

I forgot to mention that this and other functions should be 'static'.

>> +       int result = 0;
>> +       struct string_list refs_for_removal = STRING_LIST_INIT_DUP;
>> +       for_each_ref_in("refs/bisect/", mark_for_removal, (void *) &refs_for_removal);