From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 31 May 2016 20:12:16 GMT
Subject: Re: [PATCH 1/3] pretty: support "mboxrd" output format
Message-ID: <CAPig+cSrqs7W2hSz6Z4_O9U52gUJFCqTSfRL0E0b=d=bO9RCEQ@mail.gmail.com>
In-Reply-To: <20160531182932.GA27021@dcvr.yhbt.net>

On Tue, May 31, 2016 at 2:29 PM, Eric Wong <e@80x24.org> wrote:
> Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Tue, May 31, 2016 at 3:45 AM, Eric Wong <e@80x24.org> wrote:
>> > Eric Sunshine <sunshine@sunshineco.com> wrote:
> <snip>  Ah thanks, I can see your point-of-view, now.
> I always had the '^' in my mind since I've written the same
> thing in Perl and Ruby.

On reflection, even with the '^' anchor, it isn't safe the way it's
coded since '^' will match following a newline, won't it? Therefore,
because 'line' isn't necessarily NUL-terminated, the pattern could
match on some line beyond what get_one_line() considers the "current
line".

This makes the hand-coded is_mboxrd_from() even more attractive; plus
you can re-use it in patch 2.