From: Eric Sunshine Date: Sun, 07 Jan 2018 00:44:35 GMT Subject: Re: [PATCH 6/8] Doc/gitsubmodules: improve readability of certain lines Message-ID: In-Reply-To: <20180106184614.20115-7-kaartic.sivaraam@gmail.com> On Sat, Jan 6, 2018 at 1:46 PM, Kaartic Sivaraam wrote: > Signed-off-by: Kaartic Sivaraam > --- > diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt > @@ -76,9 +76,10 @@ The configuration of submodules > - * The command line for those commands that support taking submodule > - specifications. Most commands have a boolean flag '--recurse-submodules > - whether to recurse into submodules. Examples are `ls-files` or `checkout`. > + * The command line arguments of those commands that support taking submodule > + specifications. Most commands have a boolean flag '--recurse-submodules' > + which specify whether they should recurse into submodules. Examples are > + `ls-files` or `checkout`. So, this is addressing issues pointed out in my review of 4/8. It's actually fixing a problem -- missing closing quote -- introduced by 4/8. Therefore, it probably would make sense either to move this hunk into 4/8 or drop 4/8 altogether.