From: Eric Sunshine Date: Thu, 07 Dec 2017 07:32:10 GMT Subject: Re: [PATCH v2] send-email: extract email-parsing code into a subroutine Message-ID: In-Reply-To: On Wed, Dec 6, 2017 at 5:55 PM, Nathan PAYRE wrote: > Junio C Hamano : writes: >> Also "reusable in other place" is by itself not an unconditional >> plus, until readers can be convinced that that 'other place' really >> wants to be able to call this function. Is there some untold >> motivation behind this change---such as a planned update to actually >> use this helper subroutine? > > This subroutine will be used to implement, initially a new option called > "--quote-email", but became "--cite" added after "--in-reply-to". > This will permit to the user to cite a mail and reply with a patch and keep > Cc, To ... > See discussion : > https://public-inbox.org/git/20171030223444.5052-1-nathan.payre@etu.univ-lyon1.fr/ Although he didn't state so explicitly, please take Junio's question as a strong hint that you should update the commit message to include the above rationale/explanation about why you consider this a good change. The reason for including the motivation in the commit message is that you want, not only to convince Junio now that this is a useful change, but to convince future readers of the project history that this change is desirable.