From: Eric Sunshine Date: Thu, 03 Jan 2019 21:38:23 GMT Subject: Re: [Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config. Message-ID: In-Reply-To: <20190103210351.13920-3-randall.s.becker@rogers.com> On Thu, Jan 3, 2019 at 4:04 PM wrote: > A number of configuration options are not automatically detected by > configure mechanisms, including the location of Perl and Python. > > There was a problem at a specific set of operating system versions > that caused getopt to have compile errors. Account for this by > providing emulation defines for those versions. > > Signed-off-by: Randall S. Becker > --- > diff --git a/config.mak.uname b/config.mak.uname > @@ -470,7 +487,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL) > NO_MKDTEMP = YesPlease > OLD_ICONV = UnfortunatelyYes > - NO_REGEX = YesPlease > + NO_REGEX=NeedsStartEnd > NO_PTHREADS = UnfortunatelyYes Style nit (probably not worth a re-roll): you lost the whitespace surrounding '='