From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 19 Jun 2020 16:00:40 GMT
Subject: Re: [PATCH 3/3] fast-export: allow dumping the path mapping
Message-ID: <CAPig+cSkmGABkfK6MaSTYsX-okrrkk_SpGgztMvzBCT0bLjGmA@mail.gmail.com>
In-Reply-To: <20200619132923.GA2540897@coredump.intra.peff.net>

On Fri, Jun 19, 2020 at 9:29 AM Jeff King <peff@peff.net> wrote:
> [...]
> We recently taught fast-export to dump the refname mapping. Let's do the
> same thing for paths, which can reuse most of the same infrastructure.
> Note that the output format isn't unambiguous here (because paths could
> contain spaces). That's OK because this is meant to be examined by a
> human.
> [...]
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
> @@ -1244,6 +1254,8 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)
>         if (anonymized_refnames_file)
>                 anonymized_refnames_handle = xfopen(anonymized_refnames_file, "w");
> +       if (anonymized_paths_file)
> +               anonymized_paths_handle = xfopen(anonymized_paths_file, "w");

Same question as in my patch 1/1 review: Do you want to close this
file at some point?