From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 25 Oct 2017 04:07:12 GMT
Subject: Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
Message-ID: <CAPig+cSjQd=p1CdizU5oUaz91z=j02UnWLtTguWzvkjS+v6ETA@mail.gmail.com>
In-Reply-To: <xmqq8tg0j8vb.fsf@gitster.mtv.corp.google.com>

On Tue, Oct 24, 2017 at 9:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>> I definitely agree with the sentiment that as few things as possible
>> should happen between calling getenv() and using its result. I've seen
>> real bugs there from unexpected invalidation of the static buffer.
>
> Sure.  I do not think we mind xstrdup()ing the result and freeing
> after we are done, though ;-)

More specifically, xstrdup_or_null(getenv(...)), if that route is chosen.