From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 27 Feb 2025 18:35:10 GMT
Subject: Re: [RFC PATCH] config: teach `repo_config()` to allow `repo` to be NULL
Message-ID: <CAPig+cSimWQg3VbFUZfxDvy3=LQk2FByx7yYKEi6BX_0jjYhCQ@mail.gmail.com>
In-Reply-To: <20250227175456.1129840-1-usmanakinyemi202@gmail.com>

On Thu, Feb 27, 2025 at 12:55 PM Usman Akinyemi
<usmanakinyemi202@gmail.com> wrote:
> The `repo` value can be NULL if a builtin command is run outside
> any repository. The current implementation of `repo_config()` will
> fail if `repo` is NULL.
>
> If the `repo` is NULL the `repo_config()` can ignore the repository
> configuration but it should read the other configuration sources like
> the system-side configuration instead of failing.

s/side/wide/

> Teach the `repo_config()` to allow `repo` to be NULL by calling the
> `read_very_early_config()` which read config but only enumerate system
> and global settings.
>
> Suggested-by: Junio C Hamano <gitster@pobox.com>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>