From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 09 Dec 2014 23:27:39 GMT
Subject: Re: [PATCH/RFC 3/4] attr: do not attempt to expand when we know it's not a macro
Message-ID: <CAPig+cSej-7iFOJcprEnkqhsbt87htZ+OB37HE6RuiXdG_F3Yw@mail.gmail.com>
In-Reply-To: <1418133205-18213-4-git-send-email-pclouds@gmail.com>

On Tue, Dec 9, 2014 at 8:53 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> Keep track of all recognized macros in the new "maybe_macro" field.
> This this field is true, it _may_ be a macro (depending on what's in

s/This this/If this/

> the current attr stack). But if the field is false, it's definitely
> not a macro, no need to go through the whole attr stack in
> macroexpand_one() to search for one.
>
> Without this, "git grep abcdefghi" on git.git hits the inner loop in
> macroexpand_one() about 2500 times. With this, it's about 60 times.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>