From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 23 Dec 2015 20:23:25 GMT
Subject: Re: [PATCH 14/16] refs: allow ref backend to be set for clone
Message-ID: <CAPig+cSaZRAXJ+sVZgFUbWcNMzqWGtH9rgqFXjupjtTJiQVYFw@mail.gmail.com>
In-Reply-To: <567AA6DD.9000404@alum.mit.edu>

On Wed, Dec 23, 2015 at 8:51 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> On 12/03/2015 01:35 AM, David Turner wrote:
>> +     if (refs_backend_type && *refs_backend_type) {
>> +             argv_array_push(&cp.args, "--refs-backend-type");
>> +             argv_array_push(&cp.args, refs_backend_type);
>> +     }
>
> This could be shortened to
>
>     argv_array_pushf(&cp.args, "--refs-backend-type=%s", refs_backend_type);

Or, without interpolation:

    argv_array_pushl(&cp.args, "--refs-backend-type", refs_backend_type, NULL);