From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 29 Apr 2015 21:16:11 GMT
Subject: Re: [PATCH v9 5/5] t1006: add tests for git cat-file --allow-unkown-type
Message-ID: <CAPig+cSXB1fyRGTtuOGsxiBnAhVwS2DydLmVYmq-+47EAa-7-g@mail.gmail.com>
In-Reply-To: <1430312065-23443-1-git-send-email-karthik.188@gmail.com>

On Wed, Apr 29, 2015 at 8:54 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
> diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
> index ab36b1e..8362019 100755
> --- a/t/t1006-cat-file.sh
> +++ b/t/t1006-cat-file.sh
> @@ -47,6 +47,18 @@ $content"
>         test_cmp expect actual
>      '
>
> +    test_expect_success "Type of $type is correct using --allow-unkown-type" '
> +       echo $type >expect &&
> +    git cat-file -t --allow-unkown-type $sha1 >actual &&

Somehow the indentation got botched here and in the remaining tests
you added. This issue is new since v8.

> +       test_cmp expect actual
> +    '
> +
> +    test_expect_success "Size of $type is correct using --allow-unkown-type" '
> +       echo $size >expect &&
> +    git cat-file -s --allow-unkown-type $sha1 >actual &&
> +       test_cmp expect actual
> +    '
> +
>      test -z "$content" ||
>      test_expect_success "Content of $type is correct" '
>         maybe_remove_timestamp "$content" $no_ts >expect &&
> @@ -296,4 +308,21 @@ test_expect_success '%(deltabase) reports packed delta bases' '
>         }
>  '
>
> +bogus_type="bogus"
> +bogus_content="bogus"
> +bogus_size=$(strlen "$bogus_content")
> +bogus_sha1=$(echo_without_newline "$bogus_content" | git hash-object -t $bogus_type --literally -w --stdin)
> +
> +test_expect_success "Type of broken object is correct" '
> +       echo $bogus_type >expect &&
> +    git cat-file -t --allow-unkown-type $bogus_sha1 >actual &&
> +       test_cmp expect actual
> +'
> +
> +test_expect_success "Size of broken object is correct" '
> +       echo $bogus_size >expect &&
> +    git cat-file -s --allow-unkown-type $bogus_sha1 >actual &&
> +       test_cmp expect actual
> +'
> +
>  test_done
> --
> 2.4.0.rc1.250.g565e85b