From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 23 Sep 2013 20:17:46 GMT
Subject: Re: [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions
Message-ID: <CAPig+cSVeJX2wHo7TTJe2oa+_pD7EPdmMo_BGO_Bj-ZKgRD6wA@mail.gmail.com>
In-Reply-To: <1379957175-8606-1-git-send-email-benoit.person@gmail.fr>

On Mon, Sep 23, 2013 at 1:26 PM, Benoit Person <benoit.person@gmail.com> wrote:
> diff --git a/contrib/mw-to-git/t/t9365-continuing-queries.sh b/contrib/mw-to-git/t/t9365-continuing-queries.sh
> new file mode 100755
> index 0000000..6fb5df4
> --- /dev/null
> +++ b/contrib/mw-to-git/t/t9365-continuing-queries.sh
> @@ -0,0 +1,24 @@
> +#!/bin/sh
> +
> +test_description='Test the Git Mediawiki remote helper: queries w/ more than 500 results'
> +
> +. ./test-gitmw-lib.sh
> +. ./push-pull-tests.sh
> +. $TEST_DIRECTORY/test-lib.sh
> +
> +test_check_precond
> +
> +test_expect_success 'creating page w/ >500 revisions' '
> +       wiki_reset &&
> +       for i in $(seq 1 501)

s/seq/test_seq/

d17cf5f3a32f07bf (tests: Introduce test_seq;  2012-08-03)

> +       do
> +               echo "creating revision $i"

Do you want to end this line with '&&'?

> +               wiki_editpage foo "revision $i<br/>" true
> +       done
> +'
> +
> +test_expect_success 'cloning page w/ >500 revisions' '
> +       git clone mediawiki::'"$WIKI_URL"' mw_dir
> +'
> +
> +test_done
> --