From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 21 Jun 2018 21:18:13 GMT
Subject: Re: [PATCH v3 3/7] t3422: new testcases for checking when incompatible options passed
Message-ID: <CAPig+cSVJk_mf8UeOoXysMZfP5c-MFBqa3H-w+Wns6_oZ8u5Ug@mail.gmail.com>
In-Reply-To: <xmqqvaabsy6y.fsf@gitster-ct.c.googlers.com>

On Thu, Jun 21, 2018 at 4:05 PM Junio C Hamano <gitster@pobox.com> wrote:
> Elijah Newren <newren@gmail.com> writes:
> > +     # This is indented with HT SP HT.
> > +     echo "          foo();" >>foo &&
>
> I often wonder, whenever I see a need for a comment like this, if
> saying the same thing in code to make it visible is cleaner and less
> error prone way to do so, i.e. e.g.
>
>         echo "_ _foo();" | tr "_" "\011" >>foo &&

Or use q_to_tab() from test-lib-functions.h:

    echo "q qfoo();" | q_to_tab